Qt/GeneralPane: Don't trigger config change events when populating GUI.

[AdmiralCurtiss]

I ran into this while implementing a 'reset all settings' feature. Turns out that blocking signals on QWidget doesn't block events from its children, so what happened is that I called reset settings, all settings were reset, then the GUI got the request to update itself, and during the update one of the GUI elements called its 'I have been changed' signal, which stored the current GUI back to the settings, reverting my reset. Not ideal!

Is there a better way to handle this? This is the best I could come up with, but maybe someone has a less boilerplate-y idea...

[AdmiralCurtiss]

After some discussion on IRC we decided on this approach being the least boilerplate-y.

[lioncash]

Is there a better way to handle this?

Unfortunately there's no other better way to do this. There's no way to disable all signals from children on a parent-level (as far as I know)

[mbc07]

Wouldn't it be easier to just trigger an app relaunch after resetting the settings?

[AdmiralCurtiss]

I mean this technically doesn't apply to just a settings reset, this can always happen if multiple options are changed at once (through, say, a GameINI being loaded) -- it's just that so far this situation has been pretty unlikely as the only option on this panel that really makes sense to adjust on a GameINI level is dual core.

Besides, isn't it much nicer UX if you can reset settings (or possibly load a settings preset) on the fly?