Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixelShaderGen: Check uid_data for use_shader_logic_op #10488

Merged
merged 1 commit into from Feb 28, 2022

Conversation

JosJuice
Copy link
Member

On devices which have hardware support for dual source blending but not logic ops, this lets us skip performing the framebuffer fetch in situations where the game isn't actually using logic ops.

On devices which have hardware support for dual source blending
but not logic ops, this lets us skip performing the framebuffer
fetch in situations where the game isn't actually using logic ops.
Copy link
Member

@OatmealDome OatmealDome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Kirby still working fine on M1 Mac.

@JMC47 JMC47 merged commit 56a9853 into dolphin-emu:master Feb 28, 2022
10 checks passed
@JosJuice JosJuice deleted the logic-ops-logic branch February 28, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants