Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dolphin-tool features and options #10491

Merged

Conversation

Minty-Meeo
Copy link
Member

This PR adds more diagnostics to dolphin-tool. The block size, compression method, and compression level are all now accessible from the command line.

Source/Core/DiscIO/WIABlob.h Outdated Show resolved Hide resolved
Source/Core/DolphinTool/VerifyCommand.cpp Outdated Show resolved Hide resolved
Source/Core/DiscIO/WIABlob.h Outdated Show resolved Hide resolved
Source/Core/DolphinTool/VerifyCommand.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinTool/VerifyCommand.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinTool/VerifyCommand.h Outdated Show resolved Hide resolved
@Minty-Meeo
Copy link
Member Author

I'm not sure if I understand why the win x64 buildbots failed.

@Dentomologist
Copy link
Contributor

You'll need to modify DolphinTool.vcxproj to include HeaderCommand.h and HeaderCommand.cpp.

You can use 175f225 as a template for what changes to make in the .vcxproj file.

…Level flags to dolphin-tool

New dolphin-tool command: "header"
-b / --block_size
-c / --compression
-l / --compression_level

Informative RVZ/WIA header2 value "compression_level" is now a s32 instead of a u32, because negative compression is a thing.

Speaking of, it is now possible to use negative compression levels in dolphin-tool's convert command (not the GUI, though).
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@AdmiralCurtiss AdmiralCurtiss merged commit 7b0d5f2 into dolphin-emu:master Mar 20, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants