New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More dolphin-tool features and options #10491
Merged
AdmiralCurtiss
merged 1 commit into
dolphin-emu:master
from
Minty-Meeo:dolphin-tool-more-stuff
Mar 20, 2022
Merged
More dolphin-tool features and options #10491
AdmiralCurtiss
merged 1 commit into
dolphin-emu:master
from
Minty-Meeo:dolphin-tool-more-stuff
Mar 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f4f2a5
to
e597e1a
Compare
JosJuice
reviewed
Mar 15, 2022
4b4323f
to
e4d48ed
Compare
JosJuice
reviewed
Mar 18, 2022
|
I'm not sure if I understand why the win x64 buildbots failed. |
|
You'll need to modify DolphinTool.vcxproj to include HeaderCommand.h and HeaderCommand.cpp. You can use 175f225 as a template for what changes to make in the .vcxproj file. |
3337387
to
98da96f
Compare
JosJuice
reviewed
Mar 19, 2022
98da96f
to
3b0fb20
Compare
JosJuice
reviewed
Mar 19, 2022
…Level flags to dolphin-tool New dolphin-tool command: "header" -b / --block_size -c / --compression -l / --compression_level Informative RVZ/WIA header2 value "compression_level" is now a s32 instead of a u32, because negative compression is a thing. Speaking of, it is now possible to use negative compression levels in dolphin-tool's convert command (not the GUI, though).
3b0fb20
to
deba9ce
Compare
JosJuice
approved these changes
Mar 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds more diagnostics to dolphin-tool. The block size, compression method, and compression level are all now accessible from the command line.