NetPlayDialog: Display external IP/Port as seen by the traversal server. #10493
+78
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techjar
suggested changes
Mar 15, 2022
jordan-woyak
force-pushed
the
netplay-show-traversal-external-port
branch
from
2e30a67
to
e1df4fa
Compare
…er when it's used.
jordan-woyak
force-pushed
the
netplay-show-traversal-external-port
branch
from
e1df4fa
to
c058c8e
Compare
Techjar
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This changes the "External" address display to that as seen by the traversal server (when using the traversal server).
e.g. When a 2nd device on my LAN tries to host with the traversal server at port 2626 my router maps the external port to 1025.
Other routers will do similar things.
Maybe network problems can be better diagnosed with this information?
"Direct" connection display still assumes the external port is unchanged.