DiscIO: Don't return GameTDB ID for any Datel disc #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTLX01 can be either a Freeloader or Action Replay, so it's inappropriate to always use the same title and cover for it.
|
What about RELSAB (GameCube) and RABAZZ? Not sure if it's necessary though, because I had to get Lustar (GameTDB admin) to prevent them from being added since those are used by protos and crap, people kept editing the page over time with different titles. |
|
Yes, as far as I know, GameTDB no longer has any entries for those game IDs. So I don't see a need to hardcode logic for them. |
AdmiralCurtiss
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
DTLX01 can be either a Freeloader or Action Replay, so it's inappropriate to always use the same title and cover for it.