Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DolphinQt: Set emulation speed setting only when the combobox is actually touched. #10527

Merged
merged 1 commit into from Mar 22, 2022
Merged

DolphinQt: Set emulation speed setting only when the combobox is actually touched. #10527

merged 1 commit into from Mar 22, 2022

Conversation

AdmiralCurtiss
Copy link
Contributor

@JosJuice
Copy link
Member

JosJuice commented Mar 22, 2022 •
edited

You're now no longer calling SConfig::SaveSettings when the user changes the emulation speed. This PR like a good idea in general though.

@AdmiralCurtiss
Copy link
Contributor Author

Changed, though now I'm wondering whether it's a good idea to persist to disk on every change in the first place...

JosJuice
JosJuice approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could save only when the user presses the close button? But it's a matter best left for another PR either way.

@AdmiralCurtiss AdmiralCurtiss merged commit c4dfd47 into dolphin-emu:master Mar 22, 2022
@AdmiralCurtiss AdmiralCurtiss deleted the speedlimit-combobox-fix branch March 22, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@AdmiralCurtiss @JosJuice