Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Increase target and compileSdk version to 32 (Android 12L/Sv2) #10537

Merged
merged 1 commit into from Mar 27, 2022

Conversation

Simonx22
Copy link
Member

This PR updates the target and compile SDK version to 32. See the Android 12L announcement for more information on Android 12L.

I have tested this on the Android Emulator. Adding and booting games works fine.
image

It's worth noting that the on-screen controls don't play nicely with the split-screen mode:
image
However, this is nothing related to the Android SDK version and already happens on the current SDK version (31) on odd form factors, like the one you can see in the first screenshot.

@JosJuice
Copy link
Member

The behavior you're seeing with the on-screen controls is caused by us saving the positions of the controls using pixel coordinates. If you reset the placement of the controls, or if it's your first time running Dolphin after installing it, I believe the buttons will be correctly placed.

At some point we should switch over saving the control positions from using SharedPreferences to using an INI file. Maybe we should change to using floats 0.0-1.0 instead of using pixels? Alternatively we could add another "set" of saved position for folded and not folded, like we currently have two sets for landscape and portrait...

@lioncash lioncash merged commit c08a23b into dolphin-emu:master Mar 27, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants