New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple M1: Fix "Building and running unit tests" message #10585

Merged

phire merged 1 commit into dolphin-emu:master from Pokechu22:apple-m1-unit-tests-f-string

Apr 14, 2022

Contributor

Pokechu22 commented Apr 14, 2022

For {arch} to be converted, the string needs to be an f-string. See e.g. the end of https://dolphin.ci/#/builders/26/builds/2728/steps/4/logs/stdio:

Built Universal Binary successfully!
Building and running unit tests for: {arch}
Building and running unit tests for: {arch}
x86_64 Unit Tests: PASSED
arm64 Unit Tests: FAILED (1)

This change is untested, but should be checkable once the osx build occurs.


          Apple M1: Fix "Building and running unit tests" message

For {arch} to be converted, the string needs to be an f-string.

phire approved these changes

View reviewed changes

phire merged commit 36678dc into dolphin-emu:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment