Qt/MemoryViewWidget: Replace the click-to-center behavior with a scrollbar. #10612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More refactoring of this thing to make it more usable.
User-facing changes:
Keyboard keys (up/down/pageup/pagedown) can still be used like before, no major change there yet -- though they do now respect the bytes per row, which they didn't before.
Internal changes:
The table is now a member of the MemoryViewWidget rather than the widget itself. This was necessary because I made a custom scrollbar that can deal with the infinitely-long memory view (since it wraps around), and attached that to the side of the memory table but still handle it as part of the MemoryViewWidget. The scrollbar always jumps back to the center after every interaction with it, and when dragging only has a limited range until you let go and re-grab it. I think this is pretty intuitive considering what we're dealing with here, but ymmv.