Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/MemoryViewWidget: Replace the click-to-center behavior with a scrollbar. #10612

Merged

Conversation

AdmiralCurtiss
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss commented Apr 26, 2022

More refactoring of this thing to make it more usable.

User-facing changes:

  • Removes the (imo infuriating) behavior that clicking anywhere in the table centers the table on that row.
  • Instead adds a scrollbar that can be used to navigate the view.

Keyboard keys (up/down/pageup/pagedown) can still be used like before, no major change there yet -- though they do now respect the bytes per row, which they didn't before.

Internal changes:
The table is now a member of the MemoryViewWidget rather than the widget itself. This was necessary because I made a custom scrollbar that can deal with the infinitely-long memory view (since it wraps around), and attached that to the side of the memory table but still handle it as part of the MemoryViewWidget. The scrollbar always jumps back to the center after every interaction with it, and when dragging only has a limited range until you let go and re-grab it. I think this is pretty intuitive considering what we're dealing with here, but ymmv.

@Tilka
Copy link
Member

Tilka commented May 9, 2022

Do you want to do the code view next? :)

@Tilka Tilka merged commit d82f2d7 into dolphin-emu:master May 9, 2022
@AdmiralCurtiss AdmiralCurtiss deleted the memory-widget-refactoring-2 branch May 9, 2022 19:41
@AdmiralCurtiss
Copy link
Contributor Author

That's probably a good idea, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants