Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Sharpen icons #10614

Merged
merged 1 commit into from Apr 27, 2022
Merged

Android: Sharpen icons #10614

merged 1 commit into from Apr 27, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Apr 26, 2022

Create vector Wii and GameCube icons and re-import default android icons as vector graphics. Scales better on a greater range of devices and takes up less space.

The app doesn't visually change except for the Wii and GameCube tab icons because the originals were very low res.

Note - I also removed redundant settings and refresh icons for Android TV. These still appear as intended on the TV version.

Before -
before

After -
after

Create vector Wii and Gamecube icons and re-import default android icons as vector graphics. Scales better on a greater range of devices and takes up less space.
@MayImilae
Copy link
Contributor

Um be sure to check this on Android TV cause I think you're deleting some files our Android TV interface is using.

@t895
Copy link
Contributor Author

t895 commented Apr 27, 2022

@MayImilae Here's the TV icons still visible
tvicons

@MayImilae
Copy link
Contributor

So I had been meaning to address these icons for some time so I'm glad to see them fixed. If I had made these icons in the first place, I may be more attached, but these were all set up without me, so, sure. With the Android TV pic, I say this LGTM.

If you ever want to implement the icons from the Qt GUI into the Android UI, let me know! They are all already vector~ ....just not right now though I am terribly busy with the Progress Report.

@t895
Copy link
Contributor Author

t895 commented Apr 27, 2022

I'll check that out. I had no idea there were already vector icons around.

@MayImilae
Copy link
Contributor

Well they are vector on my side but they are raster in Qt. For now at least.

@t895
Copy link
Contributor Author

t895 commented Apr 27, 2022

Would you have a way of sending that? I could add that to this PR if you'd like

@MayImilae
Copy link
Contributor

Not right now, I'd need to do some prep to them and I'm waaay too busy right now. I just moved and I'm working on the Progress Report while still unpacking! For now, this PR should just be merged as is and any icon can be in a separate PR.

@t895
Copy link
Contributor Author

t895 commented Apr 27, 2022

Oh wow ok, we'll do that later. Just let me know when you have the time.

@JosJuice JosJuice merged commit 260d3fa into dolphin-emu:master Apr 27, 2022
@t895 t895 deleted the sharp-icons branch April 28, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants