Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msbuild: improve reproducible builds #10617

Merged
merged 3 commits into from Apr 27, 2022
Merged

Conversation

shuffle2
Copy link
Contributor

mostly replaces some embedded paths with fake or relative paths, which keeps outputs identical even if built from different directories.

@lioncash lioncash merged commit 3897eb5 into dolphin-emu:master Apr 27, 2022
10 checks passed
@shuffle2 shuffle2 deleted the repro branch April 27, 2022 22:40
@Pokechu22
Copy link
Contributor

This change (specifically f2c5c05) makes it impossible to set breakpoints in Visual Studio; it fails to load symbols.

@shuffle2
Copy link
Contributor Author

shuffle2 commented May 2, 2022

hm, i wonder if it just happened to work for me because I start VS from the dolphin git root directory, so the relative path happened to line up. :/
Normal usecase for pdbaltpath is to only use %_PDB% (remove all path info), but it's intended to be used with sym server/cache (where the lookup is done via guid, not path in any case).
I'll try to think of a better way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants