Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger RegisterWidget Add option to change column's display type #10621

Merged
merged 1 commit into from May 8, 2022

Conversation

TryTwo
Copy link
Contributor

@TryTwo TryTwo commented Apr 29, 2022

Adds new context options to change entire column's display type at once. I simply named it "All Hexadecimal" etc.

@TryTwo
Copy link
Contributor Author

TryTwo commented Apr 29, 2022

What about this? If yes, should I do it for the individual cell display context options as well?

@AdmiralCurtiss
Copy link
Contributor

Yeah, this works. Squash please, and no you don't need to do it for anything else. (But if you do please make it a separate commit.)

@AdmiralCurtiss
Copy link
Contributor

AdmiralCurtiss commented Apr 30, 2022

Hm actually testing this, I think it would make more sense for the float registers to set all 64 values instead of just one of the two columns. Can you add that? Or do you think that it's better as-is?

@TryTwo
Copy link
Contributor Author

TryTwo commented Apr 30, 2022

The second column is for paired singles. When it's displaying the same information as the first column, it's a little helpful having them as different types.

LFS sets both columns to the same value, LFD sets only the first column, it could be nice if it set both, but not sure if that'd be correct. PSQ sets the two columns to different values. I may be missing something, I haven't used it recently.

/edit I'd say as-is is slightly better.

@AdmiralCurtiss AdmiralCurtiss merged commit 67ee78b into dolphin-emu:master May 8, 2022
10 checks passed
@TryTwo TryTwo deleted the PR_Register_Column_Type branch May 8, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants