Android: Replace Picasso with Glide #10626
Merged
+228
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't mind switching to Glide, but unless your fix for the issue with the borders actually depends on switching to Glide, you should put that fix in a separate PR. |
|
please rebase on master to fix windows build |
t895
force-pushed
the
glide
branch
2 times, most recently
from
d3d652e
to
dad9bd1
Compare
JosJuice
reviewed
Jul 16, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/GlideUtils.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/TvUtil.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
glide
branch
4 times, most recently
from
027e3e3
to
391466a
Compare
JosJuice
reviewed
Aug 10, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/GlideUtils.java
Outdated
Show resolved
Hide resolved
|
@JosJuice Just took some time to try and get the custom covers working again. I'm not happy with the implementation I have here, but this is the only way I've found how to get the right directory for internal storage. This doesn't even allow for custom covers if the game library is stored on an external sd card. I'm just thinking about just sticking to changing the cached image to get a custom cover for now while I wait for a better solution. Note - I could not find a way to get our existing URIs to function properly |
JosJuice
reviewed
Aug 11, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/model/GameFile.java
Outdated
Show resolved
Hide resolved
t895
force-pushed
the
glide
branch
2 times, most recently
from
65f0c7f
to
d781cec
Compare
t895
force-pushed
the
glide
branch
3 times, most recently
from
2f4c452
to
f400da6
Compare
JosJuice
reviewed
Aug 28, 2022
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/model/GameFile.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Glide lets us use less code for image loading and caching. Additionally, I have put image compression on a separate thread.