Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change _WIN32 check to a _MSC_VER check in Inline.h #10628

Merged
merged 1 commit into from May 3, 2022
Merged

Change _WIN32 check to a _MSC_VER check in Inline.h #10628

merged 1 commit into from May 3, 2022
+1 −1

Conversation

Minty-Meeo
Copy link
Member

This is compiler dependent, not OS dependent.

@Minty-Meeo
Copy link
Member Author

Extract of a change from #10610. I decided this was too unrelated to be put in that PR.

@AdmiralCurtiss
Copy link
Contributor

Please give both the PR and the commit a better message that actually describes the change.

@Minty-Meeo
Change _WIN32 check to a _MSC_VER check in Inline.h
9c22205 
This is compiler dependent, not OS dependent.
@Minty-Meeo Minty-Meeo changed the title Update Inline.h Change _WIN32 check to a _MSC_VER check in Inline.h May 2, 2022
@lioncash
Copy link
Member

lioncash commented May 2, 2022

LGTM once the commit title is updated

@shuffle2
Copy link
Contributor

shuffle2 commented May 3, 2022

fwiw [[msvc::forceinline]] should also work (no preference, but mentioning because i'm not sure it's actually documented well).

@Tilka Tilka merged commit ac64382 into dolphin-emu:master May 3, 2022
10 checks passed
@Minty-Meeo Minty-Meeo deleted the force_inline-minor-change branch May 4, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@Minty-Meeo @AdmiralCurtiss @lioncash @shuffle2 @Tilka