Revert "msbuild: use pdbaltpath to strip dirname of pdb" #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the commit message and PR description, please include a short reason why. Seems reasonable other than that. |
This reverts commit f2c5c05. debuggers using path-based searching don't seem smart enough to find a relative path if it's not relative to their pwd.
shuffle2
force-pushed
the
revert-pdbaltpath
branch
from
2b050d0
to
a29b1ac
Compare
Pokechu22
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts commit f2c5c05.
debuggers using path-based searching don't seem smart enough
to find a relative path if it's not relative to their pwd.
Using pdbaltpath is only really useful for sharing build outputs between different locations (e.g. between pr and release buildbots, with how windows buildbot is currently setup). Since we don't actually cache build outputs on windows yet and sharing between locations isn't a requirement for that, we can worry about the optimization later.