AX: preparatory cleanup #10641
Merged
AX: preparatory cleanup #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
May 7, 2022
| u16 surround_delta; | ||
| u16 auxA_surround; | ||
| u16 auxA_surround_delta; | ||
| VolumeData main_left, main_right; |
There was a problem hiding this comment.
This might just be my personal preference here, but I'd rather have this on two lines.
Mostly inconsequential here, since there are no type modifiers (like *, const or whatever); but for consistency I feel it makes more sense (especially with the surround ones being ordered differently).
Suggested change
| VolumeData main_left, main_right; | |
| VolumeData main_left; | |
| VolumeData main_right; |
Thoughts?
There was a problem hiding this comment.
I kinda liked "left" being on the left and "right" being on the right^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No functional change intended.