Show a panic alert if movie is missing its starting savestate #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two exclamation marks in the same dialog box is a little unusual. Seems fine other than that. |
This comment was marked as outdated.
This comment was marked as outdated.
Pokechu22
force-pushed
the
movie-missing-savestate-warning
branch
from
5631827
to
61a144b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously, if a movie is started and its savestate is missing, then it'll just silently play the movie from the start of the game. That's not great behavior, so I added a panic alert to this case:
I've hit this case because I renamed my movie file without renaming the savestate. Other situations (such as the savestate being from an incompatible version) aren't covered (in the incompatible version case, you currently get an on-screen display message instead).