Fix all the current issues with the AArch64 register cache. #1065
+218
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,6 +33,15 @@ ARM64Reg Arm64RegCache::GetReg(void) | |||
| return INVALID_REG; | |||
| } | |||
|
|
|||
| u32 Arm64RegCache::GetUnlockedRegisters() | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sonicadvance1
force-pushed
the
AArch64-fix-regcache
branch
from
6a3025f
to
70bc58e
Compare
| @@ -292,6 +372,24 @@ void Arm64GPRCache::GetAllocationOrder(void) | |||
| m_host_registers.push_back(HostReg(reg)); | |||
| } | |||
|
|
|||
| void Arm64GPRCache::FlushMostStaleRegister(void) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixes all the current issues I've been experiencing. Scaled back the register cache idea for now so I can actually work on some real instructions. Tested this work with unit tests so I know it works. Unit tests are pretty great things.
Sonicadvance1
force-pushed
the
AArch64-fix-regcache
branch
from
70bc58e
to
e883a6f
Compare
|
Well, I can't really test this in anyway; But the code looks fine. |
skidau
added a commit
that referenced
this pull request
Sep 15, 2014
Fix all the current issues with the AArch64 register cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes all the current issues I've been experiencing.
Scaled back the register cache idea for now so I can actually work on some real instructions.
Tested this work with unit tests so I know it works.
Unit tests are pretty great things.