AX: handle DPL2 mixer control in old GameCube titles #10656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GameCube, a ramp bit has no effect if its corresponding channel is inactive. On Wii however, enabling just the ramp implicitly also enables the channel. AXSetVoiceMix() never does that, so this commit should have no impact on games unless they fiddle with the mixer control value directly.
This fixes the audio test in Rogue Squadron 2 (issue 12902).
Pokechu22
approved these changes
May 13, 2022
There was a problem hiding this comment.
Can confirm that this fixes RS2 (and doesn't cause a regression in RS3). I haven't attempted to reverse-engineer the AX ucode myself to confirm it.
Also, a fun fact (that I discovered by accident) is that there are actually 2 TIE fighters in the audio test in RS2; the one that moves in a straight line is separate from the one that rotates. This can't be seen with freelook, but it can be seen by patching 7fc15438 to 4e800020 in the US release (which stops the camera from updating - something I had enabled for other purposes and forgot that I had left it on).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In old GameCube titles the DPL2 bit implicitly activates the AUXB_LR channels. Also, setting the AUXA bit activates all three channels (LRS). This fixes the audio test in Rogue Squadron 2 (issue 12902).
The other commit is just a theoretical accuracy improvement for AXWii. In practice it should not affect any games.