IOS/DI: Fake the error 001 read when running DirectoryBlobs or Riivolution-patched games. #10666
+61
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
May 15, 2022
Source/Core/Core/BootManager.cpp
Outdated
| (std::holds_alternative<BootParameters::Disc>(boot->parameters) && | ||
| std::get<BootParameters::Disc>(boot->parameters).volume->GetBlobReader().GetBlobType() == | ||
| DiscIO::BlobType::DIRECTORY)); | ||
| Config::SetCurrent(Config::SESSION_SHOULD_FAKE_ERROR_001, should_fake_error_001); |
There was a problem hiding this comment.
Ideally this should be implemented in such a way that if the user switches discs, the hack turns on or off to match the new disc.
There was a problem hiding this comment.
Oh right, we do support mid-game disc swapping...
|
I've enabled it for DirectoryBlobs because I've run into this before while modding -- left a backup copy of an archive in the folder and suddenly it didn't boot anymore. And since that seems like the primary use case for DirectoryBlobs I imagine I'm not the first person to run into that. |
AdmiralCurtiss
force-pushed
the
riivolution-error-001
branch
from
e31f294
to
90dd8c9
Compare
…ution-patched games.
AdmiralCurtiss
force-pushed
the
riivolution-error-001
branch
from
90dd8c9
to
8d0f520
Compare
|
@JosJuice So what are we doing with this? IMO this is an acceptable hack considering how DirectoryBlob works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@JosJuice Is this what you had in mind?