Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printf-style logging #10677

Merged
merged 7 commits into from May 19, 2022
Merged

Conversation

Pokechu22
Copy link
Contributor

I've gotten annoyed by accidentally trying to use fmt strings with INFO_LOG, so I've removed the printf-based logs (now only the _FMT variants remain). This was originally planned in #9286 for after assertions were changed to fmt, which I did in #10209. Renaming the _FMT variants to the original names could be done later on.

Note that the logging in FrameDump is receiving printf format strings and args from libav, so that still needs to handle printf strings. #10572 added a separate logging method to handle this, but I've moved the formatting to within the libav log callback. An alternative would be to keep GENERIC_LOG_V (possibly renaming it to GENERIC_LOG_VPRINTF), but it's only used here so I don't know how necessary that is.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@lioncash
Copy link
Member

Nice! Good riddance to the printf-based ones

@lioncash lioncash merged commit a98d036 into dolphin-emu:master May 19, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants