Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've gotten annoyed by accidentally trying to use fmt strings with
INFO_LOG, so I've removed the printf-based logs (now only the_FMTvariants remain). This was originally planned in #9286 for after assertions were changed to fmt, which I did in #10209. Renaming the_FMTvariants to the original names could be done later on.Note that the logging in FrameDump is receiving printf format strings and args from libav, so that still needs to handle printf strings. #10572 added a separate logging method to handle this, but I've moved the formatting to within the libav log callback. An alternative would be to keep
GENERIC_LOG_V(possibly renaming it toGENERIC_LOG_VPRINTF), but it's only used here so I don't know how necessary that is.