UnitTests: Skip PageFaultTest if exception handlers aren't supported #10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page faults should only occur on architectures that support exception handlers, so skip the test on other architectures to avoid spurious test failures.
|
lgtm, please merge to fix the bot! also yes, please make another PR to update GTest to $latest (or, at least, see if it can be updated without trouble). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The nightly generic builder has been failing on the PageFaultTest because the generic build doesn't install an exception handler. This PR adds a function to see if the build supports exception handlers and skips the test if it doesn't.
Questions/Comments: