MainSettings: Make MAIN_CUSTOM_RTC_VALUE default value less magical #10684
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
May 21, 2022
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| #include "Core/Config/MainSettings.h" | |||
|
|
|||
| #include <chrono> | |||
There was a problem hiding this comment.
Ah, no, I was trying to implement it using std::chrono to do the date differences but I couldn't get it to work; that's a leftover from my attempt.
There was a problem hiding this comment.
chrono should be possible but it's a lot more verbose, even with C++20 :(
Pokechu22
force-pushed
the
custom-rtc-default-value
branch
from
dae8a99
to
863cb59
Compare
|
Sure, why not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggested in #8067 (comment).