Windows: Remove unused Qt5 block and reference #10697
Conversation
|
macOS still hasn't been updated to Qt6 yet. Is this PR fine with that? (I'd be very surprised if it wasn't based on the code but asking anyway) |
|
Yep, that code block effectively didn't exist for any platform besides Windows. |
|
IMO we should wait on removing this simple kind of glue until Qt5 doesn't work anymore for other reasons -- right now it should still compile and run fine, after all. These few lines don't hurt anything by being there. |
|
Nothing's going to break if we leave it alone, but having this code block which appears at a glance to do something but actually doesn't is a tiny bit of technical debt. I haven't seen any discussion on how long we'll maintain Qt5 support on other platforms, but it wouldn't surprise me if it lasted a year or two. Is there some benefit to keeping this around until then instead of removing it now? |
Remove a Windows/Qt5 only section of Main.cpp now that Windows has a minimum Qt version of 6.3.
The SetCurrentUserStyle comment was overly specific; the bug also occurs with light-mode macOS, Windows with Qt 6.3, or an empty stylesheet_name.