Debugger MemoryWidget: Navigate to memory from breakpoint widget and cheat search. #10701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TryTwo
force-pushed
the
PR_Memory_Widget_Connections
branch
2 times, most recently
from
4abe8d7
to
ff01445
Compare
|
Rebase and added WatchWidget a context menu option too. |
| // i18n: This kind of "watch" is used for watching emulated memory. | ||
| // It's not related to timekeeping devices. | ||
| menu->addAction(tr("Show in Memory"), this, [this, row] { ShowInMemory(row); }); |
There was a problem hiding this comment.
This line needs to be before the i18n comment.
| QMenu* menu = new QMenu(this); | ||
|
|
||
| menu->addAction(tr("Go to memory"), [this, &address] { emit ShowMemory(address); }); |
There was a problem hiding this comment.
[this, &address] -> [this, address], it's just an u32.
| @@ -361,7 +362,7 @@ void BreakpointWidget::OnContextMenu() | |||
| emit BreakpointsChanged(); | |||
| Update(); | |||
| }); | |||
| menu->addAction(tr("Go to"), [this, bp_address] { emit SelectedBreakpoint(bp_address); }); | |||
| menu->addAction(tr("Go to"), [this, &bp_address] { emit ShowCode(bp_address); }); | |||
There was a problem hiding this comment.
Why did you add the & here?
There was a problem hiding this comment.
That's just how other connection around it were passing the variable.
| @@ -372,6 +373,7 @@ void BreakpointWidget::OnContextMenu() | |||
| if (mb_iter == memory_breakpoints.end()) | |||
| return; | |||
|
|
|||
| menu->addAction(tr("Go to"), [this, &bp_address] { emit ShowMemory(bp_address); }); | |||
There was a problem hiding this comment.
This doesn't need the by-reference either.
| @@ -395,6 +396,11 @@ void WatchWidget::AddWatchBreakpoint(int row) | |||
| emit RequestMemoryBreakpoint(PowerPC::debug_interface.GetWatch(row).address); | |||
| } | |||
|
|
|||
| void WatchWidget::ShowInMemory(int row) | |||
| { | |||
| emit(ShowMemory(PowerPC::debug_interface.GetWatch(row).address)); | |||
There was a problem hiding this comment.
emit is not a function call, this should just be
emit ShowMemory(PowerPC::debug_interface.GetWatch(row).address);
TryTwo
force-pushed
the
PR_Memory_Widget_Connections
branch
from
ff01445
to
d1055ac
Compare
…end address to Memory Widget
TryTwo
force-pushed
the
PR_Memory_Widget_Connections
branch
from
d1055ac
to
177dae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When an address is sent to memory widget, it doesn't go in the memory address target box and must still be copied there before being able to get edited. This is a bit annoying, but forcibly changing the target address could be annoying as well. This wouldn't be a big issue if we could edit cells directly. I think we need another PR to improve this some way.