Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: rename minizip to minizip-ng #10704

Merged
merged 1 commit into from Jun 6, 2022
Merged

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented May 28, 2022

minizip-ng is the new name used by the upstream project as well as all distros other than Fedora (but it looks like it will be renamed there).

I've also changed the minimum version to 3.0.0 because that's when the library was renamed. Tested on Arch Linux which does not ship the unzip.h compatibility wrapper for mz_compat.h.

@shuffle2
Copy link
Contributor

shuffle2 commented May 30, 2022

i think it will need to be rebased to keep pr-android happy
edit: actually, maybe not since it doesn't add/remove files, let's see :)

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but you should rebase this so the Android build passes.

minizip-ng is the new name used by the upstream project as well as all
distros other than Fedora (but it looks like it will be renamed there).
@AdmiralCurtiss AdmiralCurtiss merged commit 86fc13f into dolphin-emu:master Jun 6, 2022
10 checks passed
@Tilka Tilka deleted the minizip branch June 30, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants