Fixes for cmake shared library detection. #10705
Conversation
|
Do ".cmake" files not need a legal header? |
A bunch of them don't, it's a bit of a mess. I'm not sure, a couple of them that we presumably sourced from elsewhere don't. |
|
|
|
I've removed the |
There was a problem hiding this comment.
Based on https://cmake.org/cmake/help/latest/command/find_package.html#search-modes it is case-sensitive for Find<PackageName>.cmake (implied by the existence of <lowercasePackageName>-config.cmake and <PackageName>Config.cmake below), and the variable name is <PackageName>_FOUND (for which we use LIBUDEV_FOUND and not Libudev_FOUND), so this seems reasonable to me. Untested.
These changes were originally going to be part of a series of changes that let dolphin build on ChromeOS, but then it...built. Anyways, these should make the cmake build steps a bit less noisy, now that it isint complaining about not having a Findfmt.cmake and hidapi can see FindLIBUDEV.cmake.
Most of the Find*.cmake files also need a bit of an overhaul, they're wildly inconsistent on capitalisation, indentation, ordering, naming, arguments, etc. I don't feel like I know enough about cmake or the coding styles, but I thought I'd put it out there. We should also have a FindQt.cmake, It'd remove the need for all the CMAKE_PREFIX_PATH nonsense and should make building on esoteric platforms or configurations much easier. Again, I don't know enough about cmake to confidently make one, just putting it out there.