DSP LLE JIT: Fix Update_SR_Register16_OverS32 #10709
Merged
+86
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There were 3 bugs here:
ORIorANDI. This change might fix bugs in official uCode, but it's unlikely.Here's my hardware tests, along with its output on real hardware, the DSP interpreter, and the recompiler before and after this change (as bin and txt from
DSPTool -p): 40bit_ins_test.zip. This test wasn't intended to find this bug, and instead will be included in a separate PR.