Fix warnings on generic builder #10721
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use reference variable bound to a temporary value
|
I don't understand the change of |
|
It's not an essential change but breaking at the end of each case, following that to the end of the switch, then seeing it continues the loop seems less clear to me than just having each case continue the loop. |
|
I'm not a fan of using |
Dentomologist
force-pushed
the
fix_warnings_on_generic_builder
branch
from
cbf4235
to
92af703
Compare
|
Ok, I removed that change. |
|
Thanks, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now that the nightly-generic builder is working it uncovered a couple warnings I haven't seen from the other builders.
The other warnings it gave are covered by #10624.