Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidManifest.xml: Re-add package="org.dolphinemu.dolphinemu" #10724

Merged
merged 1 commit into from Jun 7, 2022

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Jun 6, 2022

Without this, debug builds of Dolphin fail to launch. The OS tries to locate org.dolphinemu.dolphinemu.debug.DolphinApplication but fails to find it because its actual name is org.dolphinemu.dolphinemu.DolphinApplication.

Partially reverts PR #10649.

Without this, debug builds of Dolphin fail to launch. The OS tries
to locate org.dolphinemu.dolphinemu.debug.DolphinApplication
but fails to find it because its actual name is
org.dolphinemu.dolphinemu.DolphinApplication.

Partially reverts 6b74907.
@JosJuice JosJuice requested a review from t895 June 6, 2022 19:58
Copy link
Contributor

@t895 t895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well just revert #10649 entirely. I'm still running into build errors if we keep the namespace declaration later in the file.

Edit - I'm wrong, it works just fine

@lioncash lioncash merged commit 099aaf0 into dolphin-emu:master Jun 7, 2022
10 checks passed
@JosJuice JosJuice deleted the android-manifest-namespace branch June 7, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants