Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riivolution: Add custom extension to patch boot.bin, bi2.bin, and apploader.img. #10730

Merged
merged 4 commits into from Jul 29, 2022

Conversation

AdmiralCurtiss
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss commented Jun 8, 2022

As far as I can tell, Riivolution cannot do this on console (probably because it's not very useful on Wii games?). So here's a custom extension for it.

These work exactly like the file and folder patch commands but use dolphin_sys_file and dolphin_sys_folder instead, so eg:

<dolphin_sys_file external="bi2.bin" disc="/bi2.bin" />

If you have other suggestions for how to do this, feel free, but I think this is a fairly straightforward solution to the problem.

(Implements a request from https://forums.dolphin-emu.org/Thread-riivolution-replace-main-dol)

@AdmiralCurtiss AdmiralCurtiss force-pushed the riivolution-sysfile-patches branch 2 times, most recently from d9ba15c to 8fa12c1 Compare June 19, 2022 19:47
@JMC47
Copy link
Contributor

JMC47 commented Jun 30, 2022

This is probably fine to have, it makes the Riivolution support more complete.

@JMC47
Copy link
Contributor

JMC47 commented Jul 28, 2022

This hasn't seen any reviews in a while. Is there any reason not to merge it?

Copy link
Member

@phire phire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane

@JMC47 JMC47 merged commit 3bf1ddc into dolphin-emu:master Jul 29, 2022
11 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the riivolution-sysfile-patches branch July 29, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants