Have audio dumps apply volume #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes DTK audio being too loud, though I don't see any difference for regular audio ( The code looks good to me apart from the lint issues (select "details" and then "view all 56 lines" to see what needs to be changed, or in Visual Studio you can press Control+K then Control+D to format the current file according to those rules). |
Pokechu22
approved these changes
Jun 11, 2022
…loud" and in game audio controls having no effect)
CasualPokePlayer
force-pushed
the
audio_dump_volume_fix
branch
from
4d7e171
to
ad89217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes cases of audio dumps being "too loud" and in game audio controls having no effect within the dump.
See Issue 12945