Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: replace std::aligned_storage_t with alignas #10737

Merged
merged 1 commit into from Jun 13, 2022
Merged

Common: replace std::aligned_storage_t with alignas #10737

merged 1 commit into from Jun 13, 2022

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jun 9, 2022

C++23 deprecates std::aligned_storage_t while alignas works since C++11.

This fixes issue 12925.

@Pokechu22
Copy link
Contributor

C++20 adds std::bitcast, which could probably replace Common::BitCast with once we update. Otherwise this looks good to me.

@Tilka
Common: replace std::aligned_storage_t with alignas
59dfc43 
C++23 deprecates std::aligned_storage_t while alignas works since C++11.

This fixes issue 12925.
@JosJuice JosJuice merged commit 82b0098 into dolphin-emu:master Jun 13, 2022
@Tilka Tilka deleted the alignas branch June 30, 2022 06:43
@Pokechu22 Pokechu22 mentioned this pull request Aug 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepalani sepalani sepalani approved these changes

@CookiePLMonster CookiePLMonster CookiePLMonster approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@Tilka @Pokechu22 @sepalani @CookiePLMonster @JosJuice