Move to C++20 for non-MSVC compilers #10740
Conversation
|
well...can you think of a way to fix it such that msvc and gcc are happy? |
|
seems to have been fixed upstream: fmtlib/fmt@3e28dc0 |
|
might be interesting to see if these 2 deprecation suppressions can be removed if non-msvc builds get on c++20: https://github.com/dolphin-emu/dolphin/blob/master/Source/VSProps/Base.props#L74 |
| @@ -2198,7 +2198,7 @@ FMT_CONSTEXPR20 auto do_write_float(OutputIt out, const DecimalFP& fp, | |||
| -> OutputIt { | |||
| auto significand = fp.significand; | |||
| int significand_size = get_significand_size(fp); | |||
| static constexpr Char zero = static_cast<Char>('0'); | |||
| const Char zero = static_cast<Char>('0'); | |||
There was a problem hiding this comment.
Shouldn't this be part of a separate PR updating the fmt external to at least 3e28dc021cf38b14ac0e2b1a046f783e094bfffc?
There was a problem hiding this comment.
We should be using a git submodule but I was lazy.
There was a problem hiding this comment.
We have patches on fmt that would need to be taken care of upstream
|
@dolphin-emu-bot rebuild |
|
poke on this? |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Is this good to go? I'd love to slam the merge button on this |
|
Good from my side. |
Just checking the builders. Windows will probably fail?