Improve incremental build time for Xcode projects #10742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
reviewed
Jun 11, 2022
Adds ~20s to incremental build time in Xcode projects
OatmealDome
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Brings time for an incremental build in the CMake-generated Xcode project from ~40s to ~1s, making development much less painful (assuming you pass
-DSKIP_POSTPROCESS_BUNDLE=ONand the new-DUSE_BUNDLED_MOLTENVK=OFF). Obviously you won't get our fancy MoltenVK fbfetch this way, but for development it's very helpful.No clue why the ExternalProject_Add makes cmake generate a project that requires running a 20s shell script for every build, but it does and that wasn't something I was interested in investigating.