Fix creation of rvz with > 2mb chunk size #10743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Makes dolphin able to create rvzs of Wii discs with a > 2mb chunk size without filling them with garbage.
ProcessAndCompresswould passRVZPacka pointer to a local single-group-sized buffer, but tell it to read from the offset that it would if that buffer was the size of a chunk, making it read past the end of the buffer for groups that weren't group 0.Side note: 16mb zstandard chunks work just fine on modern computers for most games*, and decompress faster than 2mb lzma chunks
* Games that use DTK audio have trouble due to DTK audio emulation not respecting disk seek times, but they have trouble at 2mb too