Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of rvz with > 2mb chunk size #10743

Merged
merged 1 commit into from Jun 14, 2022

Conversation

TellowKrinkle
Copy link
Contributor

Makes dolphin able to create rvzs of Wii discs with a > 2mb chunk size without filling them with garbage.

ProcessAndCompress would pass RVZPack a pointer to a local single-group-sized buffer, but tell it to read from the offset that it would if that buffer was the size of a chunk, making it read past the end of the buffer for groups that weren't group 0.

Side note: 16mb zstandard chunks work just fine on modern computers for most games*, and decompress faster than 2mb lzma chunks

* Games that use DTK audio have trouble due to DTK audio emulation not respecting disk seek times, but they have trouble at 2mb too

@JMC47 JMC47 merged commit 431d757 into dolphin-emu:master Jun 14, 2022
10 checks passed
@TellowKrinkle TellowKrinkle deleted the LargeBlockRVZ branch June 15, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants