InputCommon: SDL 2.0.22 init crash workaround #10748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
approved these changes
Jun 14, 2022
|
The relevant SDL PR is libsdl-org/SDL#5598 (libsdl-org/SDL@d1a3981), for reference. (Perhaps you should include this in the commit message and/or the comment?) |
Pokechu22
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There's a fun bug in SDL 2.0.22 where it'll crash on macOS if you try to init it on something other than the main thread
It's been fixed in the latest git releases, but 2.0.24 isn't scheduled for release for a while