VideoCommon: Fix ubershaders on MoltenVK Intel #10749
Merged
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spirv-cross's MSL codegen makes the amazing choice of compiling calls to inout functions as `State temp = s; call_function(temp); s = temp`. Not all Metal backends handle this mess well. In particular, it causes register spills on Intel, losing about 5% in performance.
|
What happens on an Intel Mac if this issue is encountered? |
|
If I remember correctly: the GPU driver crashes, the system becomes temporarily unresponsive, and Dolphin locks up whenever you try to use Ubershaders. (MBP 16" 2019, Intel UHD Graphics 630) |
|
Is there a way for me to reproduce this? I could give this a quick before and after test. |
|
Should be able to reproduce by activating Ubershaders of any type, selecting the Intel GPU in the devices dropdown, and starting a game. |
|
@TellowKrinkle Is the second commit related to this PR? Seems to just be a performance fix |
|
Only as related as it's also targeting Ubershaders on Metal+Intel Should I move it to a separate PR? |
|
Eh, if it's Intel and Ubershaders, good enough for me. |
OatmealDome
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Intel's Metal driver seems to have issues with dynamic sampler indexing
Also includes a small performance fix for Intel on MoltenVK