Update supportedOS values in .manifest files #10751
Merged
+0
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jun 14, 2022
|
I forgot to mention, but the OS support situation for nogui is currently the same as for DolphinTool. I suppose nogui is more likely to break Windows 7 support in the future than DolphinTool is, though. Does anyone else have an opinion on nogui? |
|
this is a hint to windows which is used to enable certain backcompat workarounds if an app declares itself as compatible with on old version of the OS and the running OS is more recent. removing the value does not prevent it from running on downlevel OS. In any case, this PR seems fine to me. It's probably easiest to just keep the manifests in sync between all binaries, but not a big deal. |
|
Ah, in that case I suppose you can ignore my comments. |
|
(I've re-updated the commit to that end,) |
|
Poke? |
Pokechu22
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the dropping of support for Windows versions lower than 10, we should also update the .manifest files to reflect this. https://docs.microsoft.com/en-us/windows/win32/sbscs/application-manifests#supportedos