Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: detect and warn if running x64 dolphin on arm64 #10758

Merged
merged 1 commit into from Jun 23, 2022

Conversation

shuffle2
Copy link
Contributor

@shuffle2 shuffle2 commented Jun 16, 2022

this came up in conversation on irc.

@delroth
Copy link
Member

delroth commented Jun 16, 2022

@dolphin-emu-bot rebuild

@PEmu2
Copy link
Contributor

PEmu2 commented Jun 16, 2022

Are there any plans to offer ARM native builds for Windows? If ARM Windows builds aren't being tested or made available for download I'm not sure if this warning will be beneficial for users.

@Rumi-Larry
Copy link

Are there any plans to offer ARM native builds for Windows? If ARM Windows builds aren't being tested or made available for download I'm not sure if this warning will be beneficial for users.

I think that is already possible.

@JosJuice
Copy link
Member

I think that is already possible.

We're talking about us building them for users, not just about building them being possible.

@shuffle2
Copy link
Contributor Author

dolphin-emu/sadm#124

@Rumi-Larry
Copy link

I think that is already possible.

We're talking about us building them for users, not just about building them being possible.

Ahh, I thought users could already build ARM on Windows

@shuffle2
Copy link
Contributor Author

shuffle2 commented Jun 17, 2022

The infrastructure is now fully handling arm64/windows stuff, so there aren't those type of missing prereqs for this PR anymore.
Any comments about this PR itself (move to different location / better wording / etc) ?

@delroth
Copy link
Member

delroth commented Jun 22, 2022

Nitpicking: instead of being in the JIT, should this be in https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Common/x64CPUDetect.cpp instead? Seems to me like a more logical location.

If you disagree I'm fine with merging this as is, just wanted to make sure you considered that option.

@shuffle2
Copy link
Contributor Author

Nitpicking: instead of being in the JIT, should this be in https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Common/x64CPUDetect.cpp instead? Seems to me like a more logical location.

If you disagree I'm fine with merging this as is, just wanted to make sure you considered that option.

Good point, didn't think of that.

@delroth delroth merged commit 2bd72df into dolphin-emu:master Jun 23, 2022
11 checks passed
@shuffle2 shuffle2 deleted the x64-on-arm64 branch July 31, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants