New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: detect and warn if running x64 dolphin on arm64 #10758
Conversation
|
@dolphin-emu-bot rebuild |
|
Are there any plans to offer ARM native builds for Windows? If ARM Windows builds aren't being tested or made available for download I'm not sure if this warning will be beneficial for users. |
I think that is already possible. |
We're talking about us building them for users, not just about building them being possible. |
Ahh, I thought users could already build ARM on Windows |
|
The infrastructure is now fully handling arm64/windows stuff, so there aren't those type of missing prereqs for this PR anymore. |
|
Nitpicking: instead of being in the JIT, should this be in https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Common/x64CPUDetect.cpp instead? Seems to me like a more logical location. If you disagree I'm fine with merging this as is, just wanted to make sure you considered that option. |
Good point, didn't think of that. |
this came up in conversation on irc.