DSPHLE: Handle mail more accurately #10761
Conversation
|
Could you resolve merge conflicts? Otherwise LGTM. |
It's cleared whenever the uCode changes, so there's no reason to clear it in a destructor or during initialization. I've also renamed it to ClearPending.
Most of these were made unnecessary by the previous commit.
This is an accuracy improvement, though I don't think it matters for anything in practice.
This fixes booting Datel titles with DSPHLE (see https://bugs.dolphin-emu.org/issues/12943). Datel messed up their DSP initialization code, so it only works by receiving a mail later on, but if halting isn't implemented then it receives the mail too early and hangs.
|
I found a regression with this PR. It seems that if you load a state (doesn't matter where you save a state) instantly after the game boots the game will crash. This happens in every game. And this not only happens with Wii games but it also happens with Game Cube games as well. The timing to load the state to cause a crash is pretty hard to achieve with some games like Mario Kart Double Dash and Kirby's Epic Yarn. Some games like Epic Mickey have a pretty easy timing to achieve the crash. |
|
Ah yeah, m_last_mail and m_halted are not stored to the savestate. Pretty obvious in retrospect. |
Split from #10732. This (specifically the halted change) fixes booting Datel titles with DSP HLE (issue 12943).