DSPHLE: Eliminate global state in GBA and AX uCode + accuracy improvements #10768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I forgot to mention that I did test this using the GameCube Preview Disc. |
|
LGTM, fine to merge once the merge conflict is resolved. |
|
Note that #10753 (comment) should be resolved before this is merged. |
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
from
549104e
to
244c9e5
Compare
|
Gah, I just noticed that the AX uCode has similar static state - I tried checking for this, but I must have missed it. dolphin/Source/Core/Core/HW/DSPHLE/UCodes/AX.cpp Lines 659 to 665 in c8e7162 I'm going to fix that in this PR as well to avoid bumping the savestate version twice. |
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
from
244c9e5
to
c689e4b
Compare
Rumi-Larry
reviewed
Jun 23, 2022
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
from
c689e4b
to
9220088
Compare
Pokechu22
changed the title
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
3 times, most recently
from
9259ac8
to
c7872b7
Compare
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
from
c7872b7
to
fb48afd
Compare
|
What's the status here, I assume this is done? I kinda lost track of it after the stuff in #10753. |
|
Yep, this is done and ready for review. |
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
3 times, most recently
from
086531a
to
91b95ae
Compare
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
2 times, most recently
from
7916d01
to
212970e
Compare
lioncash
reviewed
Aug 4, 2022
(Apart from AXUCode, which is inherited by AXWiiUCode.)
The accuracy improvements are: * The request mail must be 0xabba0000 exactly; both the low and high parts are checked * The address is masked with 0x0fffffff * Before, the global state meant that after the GBA uCode had been used once, it would accept 0xcdd1 commands immediately. Now, it only accepts them after execution has finished.
This also increases accuracy as to when specific mail is allowed, and correctly handles masking of the 0xCDD1 mails.
CARDUCode, GBAUCode, and INITUCode previously didn't have an implementation of it. In practice it's unlikely that this caused an issue, since these uCodes are only active for a few frames at most, but now that GBAUCode doesn't have global state, we can implement it there. I also implemented it for CARDUCode, although our CARDUCode implementation does not have all states handled yet - this is simply future-proofing so that when the card uCode is properly implemented, the save state version does not need to be bumped. INITUCode does not have any state to save, though.
Pokechu22
force-pushed
the
dsp-hle-gba-class
branch
from
212970e
to
bf70026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The accuracy improvements are:
This is somewhat based on my WIP HLE version of the Card uCode, which the GBA uCode has some similarities with. I briefly checked the accuracy changes above, but I haven't done a thorough read-through of the GBA uCode myself.
This PR also bundles #10753.