Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msbuild: add pch for dolphinqt #10772

Merged
merged 1 commit into from Jun 22, 2022
Merged

msbuild: add pch for dolphinqt #10772

merged 1 commit into from Jun 22, 2022

Conversation

shuffle2
Copy link
Contributor

since this now includes Qt headers it's better than only using
the vanilla DolphinLib one alone (previous behavior before Qt6)

this PR:

c:\src\dolphin>rmdir /s/q build\x64\Release\Dolphin && powershell measure-command { msbuild -v:m -m -p:Configuration=Release,Platform=x64 Source\Core\DolphinQt\DolphinQt.vcxproj }


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 23
Milliseconds      : 777
Ticks             : 237779051
TotalDays         : 0.000275207234953704
TotalHours        : 0.00660497363888889
TotalMinutes      : 0.396298418333333
TotalSeconds      : 23.7779051
TotalMilliseconds : 23777.9051

master:

c:\src\dolphin>rmdir /s/q build\x64\Release\Dolphin && powershell measure-command { msbuild -v:m -m -p:Configuration=Release,Platform=x64 Source\Core\DolphinQt\DolphinQt.vcxproj }


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 36
Milliseconds      : 721
Ticks             : 367217774
TotalDays         : 0.000425020571759259
TotalHours        : 0.0102004937222222
TotalMinutes      : 0.612029623333333
TotalSeconds      : 36.7217774
TotalMilliseconds : 36721.7774

since this now includes Qt headers it's better than only using
the vanilla DolphinLib one alone (previous behavior before Qt6)
@delroth delroth merged commit dc61f87 into dolphin-emu:master Jun 22, 2022
11 checks passed
@shuffle2 shuffle2 deleted the morepch branch July 31, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants