Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msbuild: Add property for creating Steam builds on Windows #10780

Merged
merged 2 commits into from Sep 23, 2022

Conversation

OatmealDome
Copy link
Member

@OatmealDome OatmealDome commented Jun 24, 2022

Forgot that Windows doesn't use CMake still. Specify /p:Steam=true with msbuild to create a Steam build for Windows.

I've also added a build flag to disable the auto updater. Use /p:AutoUpdate=false to disable the auto updater functionality.

@shuffle2
Copy link
Contributor

I’m clueless about steam. What is the point of this? Is it required to submit the app to steam store?

Please rebase and put the flags in this file https://github.com/dolphin-emu/dolphin/blob/master/Source/VSProps/Base.Dolphin.props

@OatmealDome
Copy link
Member Author

@shuffle2 Rebased.

We might want to introduce Steam-specific features in the future, and since those won't work when running outside of the Steam environment, they should be locked behind a #ifdef STEAM. Steam will also handle updating for us, so we should disable our own autoupdate infrastructure since it'll interfere and be confusing for the user.

@shuffle2
Copy link
Contributor

Does it really need compile-time difference? I suppose it doesn't really matter, but seems code might be cleaner / more robust if it's just runtime-dynamic. anyway this pr is fine with me.

@AdmiralCurtiss AdmiralCurtiss merged commit 79c5d1b into dolphin-emu:master Sep 23, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants