VideoCommon: add structures to graphics mods internal API #10804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
graphics-mod-input-output-structs
branch
from
2632c06
to
b639008
Compare
This comment has been hidden.
This comment has been hidden.
6 tasks
Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/ScaleAction.cpp
Outdated
Show resolved
Hide resolved
Source/Core/VideoCommon/GraphicsModSystem/Runtime/Actions/PrintAction.cpp
Outdated
Show resolved
Hide resolved
iwubcode
force-pushed
the
graphics-mod-input-output-structs
branch
2 times, most recently
from
37ad351
to
c4785db
Compare
iwubcode
changed the title
iwubcode
force-pushed
the
graphics-mod-input-output-structs
branch
from
c4785db
to
451345e
Compare
…ng or removing parameters with less code overhead
iwubcode
force-pushed
the
graphics-mod-input-output-structs
branch
from
451345e
to
bc36058
Compare
|
@AdmiralCurtiss - thank you so much for reviewing this. Please take another look when you have time. I was being a bit dumb. Hopefully this approach is more reasonable. |
AdmiralCurtiss
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As I've started work on multiple graphics mod features, they've all needed the same thing: adding parameters to the hook API. Rather than having to update every action added every time, I think it makes more sense to have a common API of structures that can be updated, cutting down on the number of places that need changing.