Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger CodeWidget: Add filter boxes to callstack, function calls, a… #10809

Merged
merged 1 commit into from Aug 22, 2022

Conversation

TryTwo
Copy link
Contributor

@TryTwo TryTwo commented Jul 5, 2022

…nd function callers. Move symbols search box to align with changes
filters

I shortened function calls/callers to just calls/callers to make more room, if that's ok.

@AdmiralCurtiss
Copy link
Contributor

AdmiralCurtiss commented Jul 5, 2022

Please filter before you construct the objects that would never be used if filtered out anyway (in fact, I think you're leaking memory here). I would also prefer if the filtering didn't allocate a new string for each entry but I guess this isn't that big of a deal...

@TryTwo
Copy link
Contributor Author

TryTwo commented Jul 5, 2022

Good points.

Copy link
Contributor

@sepalani sepalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing the group box with a widget and renaming the labels to calls/callers, sounds fine to me.

Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/CodeWidget.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@sepalani sepalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callstack, calls, callers entries are always prefixed by * , > or < so searching for them will always match even if not in the symbol database.

TBH, I'm fine with this PR in its current state.

@TryTwo
Copy link
Contributor Author

TryTwo commented Jul 5, 2022

There's no indicator where to hover the mouse to drag up/down an individual section. I wonder if there's a border or something I can add.

…nd function callers. Move symbols search box to align with changes.
@TryTwo
Copy link
Contributor Author

TryTwo commented Jul 5, 2022

filterborder

This is the best I could do. Using "background-color: black" produced a line that was a bit annoying. The "width: 1px" doesn't do anything, but needed to be defined.

/edit background-color: lightGrey looks okay too.

@iwubcode
Copy link
Contributor

iwubcode commented Jul 6, 2022

Just wanted to say thank you so much @TryTwo !

@TryTwo
Copy link
Contributor Author

TryTwo commented Jul 7, 2022

filterborder2

I can switch it to this. Or if it seems odd to have anything I can just remove it.

@JMC47
Copy link
Contributor

JMC47 commented Aug 22, 2022

This has an approval and has been sitting for a while.

@JMC47 JMC47 merged commit 48fdbcd into dolphin-emu:master Aug 22, 2022
11 checks passed
@TryTwo TryTwo deleted the PR_CodeWidget_Filters branch August 23, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants