New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger CodeWidget: Add filter boxes to callstack, function calls, a… #10809
Conversation
|
Please filter before you construct the objects that would never be used if filtered out anyway (in fact, I think you're leaking memory here). I would also prefer if the filtering didn't allocate a new string for each entry but I guess this isn't that big of a deal... |
4dee5b0
to
bcf96b7
Compare
|
Good points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the group box with a widget and renaming the labels to calls/callers, sounds fine to me.
bcf96b7
to
104bfbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The callstack, calls, callers entries are always prefixed by * , > or < so searching for them will always match even if not in the symbol database.
TBH, I'm fine with this PR in its current state.
|
There's no indicator where to hover the mouse to drag up/down an individual section. I wonder if there's a border or something I can add. |
…nd function callers. Move symbols search box to align with changes.
104bfbc
to
d0b33c7
Compare
|
Just wanted to say thank you so much @TryTwo ! |
|
This has an approval and has been sitting for a while. |


…nd function callers. Move symbols search box to align with changes

I shortened function calls/callers to just calls/callers to make more room, if that's ok.