FileUtil: Only attempt to write to the destination in Copy if there is actually content to write #10810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s actually content to write
OatmealDome
force-pushed
the
fileutil-copy-mac-updater
branch
from
8f47e7c
to
c6eb5e2
Compare
JosJuice
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
File::Copy()fails with empty files because<<sets failbit on the destination stream if nothing was written. The macOS updater usesFile::Copy()in a workaround for an OS quirk. A recent PR added empty files to theSysfolder, breaking the macOS updater.Fixes https://bugs.dolphin-emu.org/issues/12968.