VideoCommon: Fix D3D shader compilation warnings #10819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add abs() to fix "pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them".
Initialize alpha_A and alpha_B. They were previously only initialized in cases where they were used, but D3D isn't able to figure that out.
Fix warning "loop only executes for 1 iteration(s), forcing loop to unroll" when vertex_in == 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix Direct3D shader warnings X3571 (negative pow() base), X4000 (potentially uninitialized variables), and X3557 (forced unrolling of single-iteration loop).
These warnings appear in both Direct3D 11 and 12. They all appear in Twilight Princess with Hybrid Ubershaders, though other games and settings probably trigger them as well.
Fixes most of 10578; I've been unable to trigger warning X3578 (Output value 'ocol1' is not completely initialized, see also 9994) and so suspect it's been fixed in the meantime, but I haven't bisected it.