Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgHandler: Add a check for libfmt version to fix build with libfmt-9 #10825

Merged
merged 1 commit into from Jul 11, 2022

Conversation

Rudolchr
Copy link
Contributor

@Rudolchr Rudolchr commented Jul 9, 2022

As libfmt-9.0.0 has changed the namespace of the function "is_compile_string" the build with this libfmt version fails.

This adds a check which libfmt version is used and calls "is_compile_string" with correct namespace when libfmt-9 is used.

…unction is_compile_string is called under it's new namespace
@Rudolchr
Copy link
Contributor Author

Rudolchr commented Jul 9, 2022

First reported: gentoo/gentoo#26292

Tested build and startup based on master branch.
Tested runtime based on the version Gentoo uses which is based on commit: 0f2540a
with these changes applied

@AdmiralCurtiss
Copy link
Contributor

Seems reasonable.

@AdmiralCurtiss AdmiralCurtiss merged commit 32523f1 into dolphin-emu:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants