Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake Windows build after #10673 (HLSL from SPIRV). #10829

Merged
merged 2 commits into from Jul 10, 2022
Merged

Fix CMake Windows build after #10673 (HLSL from SPIRV). #10829

merged 2 commits into from Jul 10, 2022

Conversation

AdmiralCurtiss
Copy link
Contributor

#10673 broke CMake builds on Windows, this fixes it.

iwubcode
iwubcode approved these changes Jul 10, 2022
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry about that. LGTM

@JosJuice JosJuice merged commit 6e09b13 into dolphin-emu:master Jul 10, 2022
@AdmiralCurtiss AdmiralCurtiss deleted the spirv-cross-cmake-fix branch July 10, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@AdmiralCurtiss @iwubcode @JosJuice